Add support for Directory AccessControl#261
Merged
tathamoddie merged 1 commit intoTestableIO:masterfrom Nov 16, 2017
Merged
Conversation
Contributor
|
Thanks! Shipped to NuGet in 2.1.0.175 |
Contributor
Author
|
Thanks! |
Contributor
Author
What are your thoughts on ^ @tathamoddie? Happy to submit a PR for this change if it makes sense (guess you'd bump the major if adhering to SemVer)? |
Contributor
|
Could it be added as an optional overload? For For |
Contributor
Author
|
I can add it as an overload on the constructor? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #259 (meant to branch for the PR as opposed to creating on master).
Add support for both getting and setting AccessControl on directories.
It looks like the implementation of
AddDirectory(string path)onMockFileSystemshould also accept aMockDirectoryDataparameter, similar to howAddFile(string path, MockFileData mockFile)acceptsMockFileData. This PR doesn't include that change